Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix constructor Error replaced with new sp(device, options) #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

malekbenz
Copy link

SerialPort don't conatin any sp.SerialPort contructor (module.exports = SerialPort;)
so this line:
modem.port = new sp.SerialPort(device, options);
should be replace with :
modem.port = new sp(device, options);

@adhisimon
Copy link

I confirm @malekbenz patch solve my problem

@mckoy03
Copy link

mckoy03 commented Aug 12, 2018

Hi,

what version of Node/npm you use? I can't seem to make it work on my environment. TIA

@jay-ike
Copy link

jay-ike commented Jul 1, 2022

Sorry but according to the API SerialPort the constructor of serialport is :
SerialPort({path,...})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants