Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move default config to installed file #434

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Move default config to installed file #434

wants to merge 2 commits into from

Conversation

emersion
Copy link
Owner

  • This doesn't work well during development: /etc/mako/config is used as defaults, the user-provided config/flags are loaded on top, but /etc/mako/config might not be installed in which case mako won't run at all.
  • Write docs

@emersion emersion mentioned this pull request Jun 28, 2022
Open
@RaoulHC
Copy link

RaoulHC commented Oct 6, 2022

Would it make sense to add SYSCONFDIR "mako/config" as an option here and provide a default file that can go there, but leave the rest of the default setting as is? That way it will still work even if it isn't present (and it probably shouldn't assume that it will be).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emersion @RaoulHC