config: ignore leading and trailing whitespace #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, there is a bug in this. If there is no newline after the last line, the last character is not read (since len is decremented by 1). I'm rebasing and force-pushing the fix. |
pranjalkole
force-pushed
the
master
branch
2 times, most recently
from
fdd84e2
to
77f8164
Compare
|
I thought I would implement the "strip leading whitespace" in another commit, but it was small, so added here. PS: Sorry for the noise |
pranjalkole
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
Leading and trailing whitespace is now stripped before parsing the line. getline returns line length, so strlen calls have been replaced with that. Also, getline now runs until -1 is returned. Additionally, the entire line (whitespace stripped) is now printed to stderr when mako fails to parse an option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leading and trailing whitespace is now stripped before parsing the line.
getline returns line length, so strlen calls have been replaced with
that. Also, getline now runs until -1 is returned.
Additionally, the entire line (whitespace stripped) is now
printed to stderr when mako fails to parse an option.
Closes #107 and #282