feat(frontend): improve portfolio chart loading and i18n - #1253
Merged
emdevelopa merged 1 commit intoJul 25, 2026
Merged
Conversation
|
Someone is attempting to deploy a commit to the Emmanuel's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@nomsoscript Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1131
Closes #1132
Closes #1130
Closes #1133
Summary
This PR resolves the first two Portfolio Chart Widget issues assigned under
nomsoscriptby improving the widget loading UX and adding internationalization support for labels and value formatting.What changed
next-intlsetup with a dedicatedportfolioChartWidgetnamespaceuseLocale()andlocaleToLanguageTag(...)Why
These changes make the Portfolio Chart Widget feel more stable during refreshes and bring it in line with the app's existing locale system so labels and formatted values adapt to the user's language.
Notes
#1130and#1133are still follow-up items, so they are referenced here without auto-closing them