Fix taxonomy links missing from admin sidebar by eyupcanakman · Pull Request #93 · emdash-cms/emdash

eyupcanakman · 2026-04-02T12:45:07Z

What does this PR do?

Closes #68

The admin sidebar hardcoded only "Categories" and "Tags" links. Any taxonomy created at runtime never showed up, so there was no way to manage its terms from the UI.

The fix loads taxonomy definitions from the database into the manifest and renders sidebar links from that list instead of a static array.

Type of change

Checklist

I have read CONTRIBUTING.md
pnpm typecheck passes
pnpm --silent lint:json | jq '.diagnostics | length' returns 0
pnpm test passes (or targeted tests for my change)
pnpm format has been run
I have added/updated tests for my changes (if applicable)
I have added a changeset (if this PR changes a published package)
New features link to an approved Discussion: https://github.com/emdash-cms/emdash/discussions/...

AI-generated code disclosure

This PR includes AI-generated code

Screenshots / test output

N/A

changeset-bot · 2026-04-02T12:45:15Z

🦋 Changeset detected

Latest commit: 90fc110

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
emdash	Patch
@emdash-cms/admin	Patch
@emdash-cms/cloudflare	Patch
@emdash-cms/plugin-ai-moderation	Patch
@emdash-cms/plugin-atproto	Patch
@emdash-cms/plugin-audit-log	Patch
@emdash-cms/plugin-color	Patch
@emdash-cms/plugin-embeds	Patch
@emdash-cms/plugin-forms	Patch
@emdash-cms/plugin-webhook-notifier	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-04-05T07:27:46Z

Overlapping PRs

This PR modifies files that are also changed by other open PRs:

feat(admin): add Taxonomy Types management page #213 (3 shared files)
Store CSS classes, make editor toolbar extensible #143 (3 shared files)

This may cause merge conflicts or duplicated work. A maintainer will coordinate.

pkg-pr-new · 2026-04-05T07:43:58Z

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@93

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@93

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@93

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@93

emdash

npm i https://pkg.pr.new/emdash@93

create-emdash

npm i https://pkg.pr.new/create-emdash@93

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@93

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@93

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@93

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@93

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@93

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@93

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@93

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@93

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@93

commit: 90fc110

github-actions · 2026-04-05T07:44:07Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR fixes missing runtime-created taxonomy links in the admin sidebar by sourcing taxonomy definitions dynamically and exposing them via the manifest.

Changes:

Load taxonomy definitions from the DB at runtime and include them in the manifest (and hash).
Extend manifest types in core and admin to include taxonomy definitions.
Render admin sidebar taxonomy links from the manifest instead of hardcoding Categories/Tags.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
packages/core/src/emdash-runtime.ts	Loads taxonomy definitions from DB, includes them in manifest + hash.
packages/core/src/astro/types.ts	Adds `taxonomies` to the core `EmDashManifest` type.
packages/core/src/astro/routes/api/manifest.ts	Ensures the “default” manifest shape includes `taxonomies: []`.
packages/admin/src/lib/api/client.ts	Extends admin-side manifest typing to include `taxonomies`.
packages/admin/src/components/Sidebar.tsx	Builds taxonomy sidebar links from manifest-provided taxonomies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-05T07:45:58Z

+			const rows = await this.db.selectFrom("_emdash_taxonomy_defs").selectAll().execute();
+			manifestTaxonomies = rows.map((row) => ({
+				name: row.name,
+				label: row.label,
+				labelSingular: row.label_singular ?? undefined,
+				hierarchical: row.hierarchical === 1,
+				collections: row.collections ? JSON.parse(row.collections) : [],


The manifest hash can become non-deterministic because selectAll().execute() has no explicit ordering, so DB row order may vary between runs (and JSON.stringify(manifestTaxonomies) will then vary). This can cause unnecessary cache invalidations. Make the taxonomy query ordering stable (e.g., orderBy('name')) and/or sort manifestTaxonomies before hashing (and consider sorting nested collections too if ordering isn’t guaranteed).

Suggested change

const rows = await this.db.selectFrom("_emdash_taxonomy_defs").selectAll().execute();

manifestTaxonomies = rows.map((row) => ({

name: row.name,

label: row.label,

labelSingular: row.label_singular ?? undefined,

hierarchical: row.hierarchical === 1,

collections: row.collections ? JSON.parse(row.collections) : [],

const rows = await this.db

.selectFrom("_emdash_taxonomy_defs")

.selectAll()

.orderBy("name")

.execute();

manifestTaxonomies = rows.map((row) => ({

name: row.name,

label: row.label,

labelSingular: row.label_singular ?? undefined,

hierarchical: row.hierarchical === 1,

collections: row.collections

? (JSON.parse(row.collections) as string[]).sort((a, b) => a.localeCompare(b))

: [],

Copilot · 2026-04-05T07:45:59Z

+			JSON.stringify(manifestCollections) +
+				JSON.stringify(manifestPlugins) +
+				JSON.stringify(manifestTaxonomies),


The manifest hash can become non-deterministic because selectAll().execute() has no explicit ordering, so DB row order may vary between runs (and JSON.stringify(manifestTaxonomies) will then vary). This can cause unnecessary cache invalidations. Make the taxonomy query ordering stable (e.g., orderBy('name')) and/or sort manifestTaxonomies before hashing (and consider sorting nested collections too if ordering isn’t guaranteed).

Copilot · 2026-04-05T07:45:59Z

+			manifestTaxonomies = rows.map((row) => ({
+				name: row.name,
+				label: row.label,
+				labelSingular: row.label_singular ?? undefined,
+				hierarchical: row.hierarchical === 1,
+				collections: row.collections ? JSON.parse(row.collections) : [],
+			}));


JSON.parse(row.collections) can throw for a single malformed row, which will currently drop all taxonomies due to the outer try/catch. Consider parsing per-row (catching/handling errors locally and defaulting that row’s collections to []), so one bad entry doesn’t remove the entire taxonomy list from the manifest.

Suggested change

manifestTaxonomies = rows.map((row) => ({

name: row.name,

label: row.label,

labelSingular: row.label_singular ?? undefined,

hierarchical: row.hierarchical === 1,

collections: row.collections ? JSON.parse(row.collections) : [],

}));

manifestTaxonomies = rows.map((row) => {

let collections: string[] = [];

if (row.collections) {

try {

collections = JSON.parse(row.collections);

} catch (error) {

console.debug(

`EmDash: Could not parse collections for taxonomy definition "${row.name}":`,

error,

);

}

}

return {

name: row.name,

label: row.label,

labelSingular: row.label_singular ?? undefined,

hierarchical: row.hierarchical === 1,

collections,

};

});

Copilot · 2026-04-05T07:45:59Z

+	taxonomies?: Array<{
+		name: string;
+		label: string;
+		labelSingular?: string;
+		hierarchical: boolean;
+		collections: string[];
+	}>;


In core, EmDashManifest.taxonomies is required, and the API default manifest also always returns taxonomies: []. On the admin side it’s typed as optional (taxonomies?), which makes consumers handle an unnecessary undefined case and can hide contract mismatches. Consider making taxonomies required in AdminManifest (and in SidebarNavProps, where it’s also optional) and relying on the backend to provide an empty array when none exist.

ascorbic · 2026-04-11T08:43:15Z

@eyupcanakman this would be great to get in. Could you address the revew comments?

- Order taxonomy query by name for deterministic manifest hash - Make taxonomies required in AdminManifest and SidebarNavProps - Add changeset for emdash and @emdash-cms/admin

- Add tests for seeded and custom taxonomy loading from DB - Add taxonomies field to AdminManifest test fixtures

eyupcanakman · 2026-04-11T12:51:38Z

Addressed the review comments. Added orderBy, sorted collections for stable hashing, and made taxonomies required. Skipped the per-row try/catch since our own code writes that column.

ascorbic

Thanks!

* Fix taxonomy links missing from admin sidebar * Address review feedback and add changeset - Order taxonomy query by name for deterministic manifest hash - Make taxonomies required in AdminManifest and SidebarNavProps - Add changeset for emdash and @emdash-cms/admin * Add taxonomy manifest tests and fix test fixtures - Add tests for seeded and custom taxonomy loading from DB - Add taxonomies field to AdminManifest test fixtures * Sort taxonomy collections for deterministic manifest hash * style: format --------- Co-authored-by: emdashbot[bot] <emdashbot[bot]@users.noreply.github.com>

github-actions Bot added the needs-approval label Apr 5, 2026

github-actions Bot mentioned this pull request Apr 5, 2026

feat(admin): add Taxonomy Types management page #213

Open

11 tasks

github-actions Bot added the overlap label Apr 5, 2026

github-actions Bot mentioned this pull request Apr 5, 2026

Store CSS classes, make editor toolbar extensible #143

Open

15 tasks

Copilot AI review requested due to automatic review settings April 5, 2026 07:39

github-actions Bot added area/admin area/core size/M labels Apr 5, 2026

Copilot AI reviewed Apr 5, 2026

View reviewed changes

Copilot started reviewing on behalf of ascorbic April 5, 2026 07:56 View session

github-actions Bot added cla: signed and removed needs-approval labels Apr 5, 2026

This was referenced Apr 8, 2026

Add admin-configurable settings for marketplace #384

Closed

Feat/atproto oauth #418

Closed

ascorbic added the Awaiting author response label Apr 11, 2026

eyupcanakman added 3 commits April 11, 2026 11:45

Fix taxonomy links missing from admin sidebar

adf6473

Address review feedback and add changeset

7aa9d9f

- Order taxonomy query by name for deterministic manifest hash - Make taxonomies required in AdminManifest and SidebarNavProps - Add changeset for emdash and @emdash-cms/admin

Add taxonomy manifest tests and fix test fixtures

bb3d72d

- Add tests for seeded and custom taxonomy loading from DB - Add taxonomies field to AdminManifest test fixtures

eyupcanakman force-pushed the fix/taxonomy-sidebar-missing branch from e34420c to bb3d72d Compare April 11, 2026 08:55

eyupcanakman and others added 2 commits April 11, 2026 12:59

Sort taxonomy collections for deterministic manifest hash

76d5039

style: format

90fc110

ascorbic approved these changes Apr 11, 2026

View reviewed changes

ascorbic merged commit a5e0603 into emdash-cms:main Apr 11, 2026
26 checks passed

emdashbot Bot mentioned this pull request Apr 11, 2026

ci: release #396

Closed

emdashbot Bot mentioned this pull request Apr 12, 2026

ci: release #486

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix taxonomy links missing from admin sidebar#93

Fix taxonomy links missing from admin sidebar#93
ascorbic merged 5 commits into
emdash-cms:mainfrom
eyupcanakman:fix/taxonomy-sidebar-missing

eyupcanakman commented Apr 2, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Apr 2, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 5, 2026

Uh oh!

pkg-pr-new Bot commented Apr 5, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 5, 2026

Uh oh!

Copilot AI Apr 5, 2026

Uh oh!

Copilot AI Apr 5, 2026

Uh oh!

Copilot AI Apr 5, 2026

Uh oh!

ascorbic commented Apr 11, 2026

Uh oh!

eyupcanakman commented Apr 11, 2026

Uh oh!

ascorbic left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

eyupcanakman commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

Checklist

AI-generated code disclosure

Screenshots / test output

Uh oh!

changeset-bot Bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Apr 5, 2026

Overlapping PRs

Uh oh!

pkg-pr-new Bot commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

ascorbic commented Apr 11, 2026

Uh oh!

eyupcanakman commented Apr 11, 2026

Uh oh!

ascorbic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

eyupcanakman commented Apr 2, 2026 •

edited

Loading

changeset-bot Bot commented Apr 2, 2026 •

edited

Loading

pkg-pr-new Bot commented Apr 5, 2026 •

edited

Loading

github-actions Bot commented Apr 5, 2026 •

edited

Loading