fix(core): add controlled media usage activation by khoinguyenpham04 · Pull Request #2445 · emdash-cms/emdash

khoinguyenpham04 · 2026-08-12T21:08:24Z

What does this PR do?

Adds a deliberate, administrator-controlled way to turn on automatic Media Usage indexing after a production deployment is ready.

The indexing foundation stays dormant until an administrator explicitly starts activation. This PR provides that final safety gate:

administrators can read a redacted activation status without exposing internal lease tokens or database errors;
each confirmed request activates at most one collection, so work stays bounded and can safely resume after interruption;
activation requires schema:manage; bearer-token calls need the admin scope, session-based POSTs need CSRF protection, and every POST requires explicit confirmation that writers are stopped and background maintenance is ready;
existing leases, retries, trigger verification, and fail-closed writer protection remain responsible for correctness;
activation never starts automatically, never runs historical reconciliation in the request, and never claims that historical coverage is already complete;
the TypeScript client, OpenAPI reference, REST documentation, and Cloudflare and Node deployment guides explain the same operator workflow;
V1 behavior and logged-out query counts remain unchanged.

An active result means that new content changes are being captured. Historical content continues to catch up through the bounded background reconciliation added by #2443.

This is stacked directly on #2443 and should be reviewed relative to feature/media-usage-automatic-reconciliation.

Type of change

Checklist

I have read CONTRIBUTING.md
pnpm typecheck passes
pnpm lint passes
pnpm test passes (or targeted tests for my change)
pnpm format has been run
I have added/updated tests for my changes (if applicable)
User-visible strings in the admin UI are wrapped for translation (not applicable; this PR adds no admin UI or user-facing UI strings)
I have added a changeset (if this PR changes a published package)
New features link to an approved Discussion: not applicable; this completes controlled activation for the existing Media Usage indexing system

AI-generated code disclosure

This PR includes AI-generated code — model/tool: OpenAI Codex (GPT-5) with GPT-5.6 Terra adversarial review

Screenshots / test output

No visual changes.

Verified locally:

full core suite: 5,620 passed, 5 skipped;
real D1/workerd activation suite: 8 passed;
fresh focused API, OpenAPI, and client suite: 75 passed;
typecheck, type-aware lint, quick lint, formatting, core and documentation builds, OpenAPI validation, and Changesets validation;
SQLite and D1 logged-out query counts and SQL snapshots are unchanged;
the worst measured activation batch used 21 D1 queries, below the 40-query safety gate;
a final GPT-5.6 Terra xhigh adversarial review found no bugs.

PostgreSQL and Durable Object SQL runtime tests were not available locally. Their shared code paths are typechecked, while the available SQLite and real D1/workerd tests cover the public activation contract and bounded request behavior.

Try this PR

Open a fresh playground →

A full working EmDash site, deployed from this branch. Each visit gets its own session-scoped sandbox: no login needed and no shared state. Try the admin, edit content, hit the public site.

_{Tracks feature/media-usage-production-activation. Updated automatically when the playground redeploys.}

…utomatic-reconciliation # Conflicts: # .changeset/safe-collection-deletion.md # packages/core/src/database/migrations/runner.ts # packages/core/src/database/repositories/media-usage.ts # packages/core/src/database/types.ts # packages/core/src/emdash-runtime.ts # packages/core/src/media/usage/collection-deletion-processor.ts # packages/core/src/media/usage/collection-deletion.ts # packages/core/tests/integration/database/media-usage-incremental-work-migration.test.ts # packages/core/tests/integration/database/migrations.test.ts # packages/core/tests/integration/runtime/media-usage-scheduled-driver.test.ts # packages/core/tests/workerd/media-usage-collection-deletion-d1.test.ts

changeset-bot · 2026-08-12T21:08:30Z

🦋 Changeset detected

Latest commit: 733e0bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages

Name	Type
emdash	Patch
@emdash-cms/cloudflare	Patch
@emdash-cms/sandbox-workerd	Patch
@emdash-cms/plugin-mcp-smoke	Patch
@emdash-cms/fixture-perf-site	Patch
@emdash-cms/perf-demo-site	Patch
@emdash-cms/cache-demo-site	Patch
@emdash-cms/do-demo-site	Patch
@emdash-cms/do-solo-demo-site	Patch
@emdash-cms/admin	Patch
@emdash-cms/auth	Patch
@emdash-cms/blocks	Patch
@emdash-cms/gutenberg-to-portable-text	Patch
@emdash-cms/x402	Patch
create-emdash	Patch
@emdash-cms/auth-atproto	Patch
@emdash-cms/plugin-embeds	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-08-12T21:08:37Z

Scope check

This PR changes 1,113 lines across 16 files. Large PRs are harder to review and more likely to be closed without review.

If this scope is intentional, no action needed. A maintainer will review it. If not, please consider splitting this into smaller PRs.

See CONTRIBUTING.md for contribution guidelines.

github-actions · 2026-08-13T18:25:54Z

Overlapping PRs

This PR modifies files that are also changed by other open PRs:

feat(core): built-in SMTP email transport for generic SMTP credentials #2156 (3 shared files)
Add deployment-managed core migration primitives #2437 (4 shared files)
feat(content): filter indexed custom fields #2213 (3 shared files)
feat(core): add getBylines() for listing a site's bylines #2352 (3 shared files)
feat(core): configurable titleField and dateField per collection #1973 (4 shared files)
feat(media): show where media is used #2225 (4 shared files)
feat: gate sandboxed plugins behind Worker Loader so free-tier Cloudflare deploys work #2351 (4 shared files)

This may cause merge conflicts or duplicated work. A maintainer will coordinate.

cloudflare-workers-and-pages · 2026-08-14T10:47:56Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Updated (UTC)
✅ Deployment successful! View logs	docs	`733e0bb`	Aug 27 2026, 10:13 AM

pkg-pr-new · 2026-08-14T15:13:51Z

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/admin@2445

@emdash-cms/auth

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/auth@2445

@emdash-cms/auth-atproto

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/auth-atproto@2445

@emdash-cms/blocks

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/blocks@2445

@emdash-cms/cloudflare

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/cloudflare@2445

@emdash-cms/contentful-to-portable-text

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/contentful-to-portable-text@2445

emdash

npm i https://pkg.pr.new/emdash-cms/emdash@2445

create-emdash

npm i https://pkg.pr.new/emdash-cms/emdash/create-emdash@2445

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/gutenberg-to-portable-text@2445

@emdash-cms/plugin-cli

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/plugin-cli@2445

@emdash-cms/plugin-types

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/plugin-types@2445

@emdash-cms/registry-client

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/registry-client@2445

@emdash-cms/registry-lexicons

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/registry-lexicons@2445

@emdash-cms/registry-moderation

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/registry-moderation@2445

@emdash-cms/registry-verification

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/registry-verification@2445

@emdash-cms/sandbox-workerd

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/sandbox-workerd@2445

@emdash-cms/x402

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/x402@2445

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/plugin-ai-moderation@2445

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/plugin-atproto@2445

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/plugin-audit-log@2445

@emdash-cms/plugin-color

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/plugin-color@2445

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/plugin-embeds@2445

@emdash-cms/plugin-field-kit

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/plugin-field-kit@2445

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/plugin-forms@2445

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/emdash-cms/emdash/@emdash-cms/plugin-webhook-notifier@2445

commit: 733e0bb

…roduction-activation

cloudflare-workers-and-pages · 2026-08-26T15:14:17Z

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://feature-media-usage-production-activation.try.emdashcms.com, https://feature-media-usage-production-activation-emdash-playground.emdash-cms.workers.dev (commit `733e0bb`)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status	Deployment URL	Commit	Updated (UTC)	See this deployment's details
Build: Success ✅ Deployment: Success ✅ View logs ↗	https://c341bc82.try.emdashcms.com, https://c341bc82-emdash-playground.emdash-cms.workers.dev	`733e0bb`	2026-08-27T10:17:09.302Z	Visit the dashboard ↗
Build: Failed ❌ View logs ↗		`7361ca3`	2026-08-26T15:24:12.847Z	View logs ↗

khoinguyenpham04 added 22 commits August 12, 2026 11:45

feat(core): add guarded collection deletion foundation

ba4646a

feat(core): safely detach activated collections

302ac9e

feat(core): process bounded collection deletion cleanup

a576d10

feat(core): expose collection deletion recovery controls

83dbf0c

fix(cloudflare): harden collection deletion guards

2d36e13

fix(core): bound collection deletion completion checks

725ef86

fix(core): use database time for deletion progress

110f945

chore(core): register collection deletion schemas

1d81a96

chore(core): keep deletion lease guards transaction-scoped

808d03e

fix(core): preserve collection deletion compatibility

26e4b26

fix(cloudflare): pin mutation reads to DO primary

90f01f8

feat(media): add reconciliation coordinator state

e2a18b6

feat(media): add bounded reconciliation scan

136ece4

feat(media): finalize automatic reconciliation

e3d35a2

feat(media): schedule automatic reconciliation

da3101d

fix(media): preserve scheduled maintenance compatibility

5ce7f25

docs: clarify automatic reconciliation changeset

8c8c0e0

feat: expose media usage activation status

36b58d2

feat: advance media usage activation safely

61d0cbd

docs: add controlled activation runbook

a90b089

docs: clarify media usage activation changeset

f312ebe

github-actions Bot added review/needs-review No maintainer or bot review yet area/core area/docs size/XL labels Aug 12, 2026

github-actions Bot added the cla: signed label Aug 12, 2026

khoinguyenpham04 added the bot:review Trigger an emdashbot code review on this PR label Aug 12, 2026

Base automatically changed from feature/media-usage-automatic-reconciliation to main August 13, 2026 12:29

github-actions Bot added the overlap label Aug 13, 2026

github-actions Bot added the needs-rebase label Aug 14, 2026

docs: clarify media usage activation guidance

4366e83

github-actions Bot added review/needs-rereview Author pushed changes since the last review area/cloudflare area/templates and removed review/approved Approved; no new commits since labels Aug 14, 2026

Merge origin/main into feature/media-usage-production-activation

c862530

github-actions Bot removed the needs-rebase label Aug 14, 2026

This was referenced Aug 14, 2026

fix(admin): show where local media is used #2470

Merged

fix(core): prepare seeded media usage #2472

Merged

ascorbic approved these changes Aug 17, 2026

View reviewed changes

github-actions Bot added review/approved Approved; no new commits since and removed review/needs-rereview Author pushed changes since the last review labels Aug 17, 2026

github-actions Bot mentioned this pull request Aug 17, 2026

feat(admin): add Media Usage setup and indexing progress #2531

Closed

18 tasks

Merge remote-tracking branch 'origin/main' into feature/media-usage-p…

2da97bf

…roduction-activation

This was referenced Aug 18, 2026

feat: complete media usage tracking setup #2538

Merged

feat(media): add flat folder API foundation #2584

Merged

Merge origin/main into feature/media-usage-production-activation

3d6bbbc

github-actions Bot mentioned this pull request Aug 21, 2026

feat(media): add flat folder UI #2586

Merged

18 tasks

Merge remote-tracking branch 'origin/main' into feature/media-usage-p…

7361ca3

…roduction-activation

Merge current main into media usage activation

733e0bb

khoinguyenpham04 merged commit f6da16b into main Aug 27, 2026
48 checks passed

khoinguyenpham04 deleted the feature/media-usage-production-activation branch August 27, 2026 13:18

emdashbot Bot mentioned this pull request Aug 27, 2026

ci: release #2625

Open

Navigation Menu

Uh oh!

fix(core): add controlled media usage activation - #2445

fix(core): add controlled media usage activation#2445
khoinguyenpham04 merged 28 commits into
mainfrom
feature/media-usage-production-activation

khoinguyenpham04 commented Aug 12, 2026 •

edited by github-actions Bot

Loading

Uh oh!

changeset-bot Bot commented Aug 12, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 12, 2026

Uh oh!

github-actions Bot commented Aug 13, 2026

Uh oh!

cloudflare-workers-and-pages Bot commented Aug 14, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Aug 14, 2026 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages Bot commented Aug 26, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

khoinguyenpham04 commented Aug 12, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

Checklist

AI-generated code disclosure

Screenshots / test output

Try this PR

Uh oh!

changeset-bot Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Aug 12, 2026

Scope check

Uh oh!

github-actions Bot commented Aug 13, 2026

Overlapping PRs

Uh oh!

cloudflare-workers-and-pages Bot commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying with Cloudflare Workers

Uh oh!

pkg-pr-new Bot commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloudflare-workers-and-pages Bot commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://feature-media-usage-production-activation.try.emdashcms.com, https://feature-media-usage-production-activation-emdash-playground.emdash-cms.workers.dev (commit 733e0bb)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

khoinguyenpham04 commented Aug 12, 2026 •

edited by github-actions Bot

Loading

changeset-bot Bot commented Aug 12, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Aug 14, 2026 •

edited

Loading

pkg-pr-new Bot commented Aug 14, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Aug 26, 2026 •

edited

Loading

Preview URL: https://feature-media-usage-production-activation.try.emdashcms.com, https://feature-media-usage-production-activation-emdash-playground.emdash-cms.workers.dev (commit `733e0bb`)