Skip to content

i18n(id): translate media detail URL label#1514

Merged
ascorbic merged 1 commit into
emdash-cms:mainfrom
ahliweb:i18n/id-url-label
Jun 17, 2026
Merged

i18n(id): translate media detail URL label#1514
ascorbic merged 1 commit into
emdash-cms:mainfrom
ahliweb:i18n/id-url-label

Conversation

@ahliweb

@ahliweb ahliweb commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes the missing Indonesian translation for the media detail URL label by translating URL: as URL: in packages/admin/src/locales/id/messages.po.

This PR updates only the Indonesian PO catalog and leaves all other locales untouched.

No changeset is included for this translation-only catalog update.

Closes #1513

Type of change

  • Bug fix
  • Feature (requires maintainer-approved Discussion)
  • Refactor (no behavior change)
  • Translation
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • I have read CONTRIBUTING.md
  • pnpm typecheck passes
  • pnpm lint passes
  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • User-visible strings in the admin UI are wrapped for translation (if applicable). Do not include messages.po changes except in translation PRs — a workflow extracts catalogs on merge to main.
  • I have added a changeset (if this PR changes a published package)
  • New features link to an approved Discussion: https://github.com/emdash-cms/emdash/discussions/...

AI-generated code disclosure

  • This PR includes AI-generated code — model/tool: OpenCode with GPT-5.4

Screenshots / test output

  • pnpm format
  • pnpm lint
  • pnpm typecheck ❌ fails in packages/plugin-cli on missing exports from @emdash-cms/plugin-types; unrelated to this PO-only change
  • pnpm --filter @emdash-cms/admin test -- --run ❌ existing browser/runtime baseline failures unrelated to this PO-only change (React hook/runtime import issues, plugin-types export mismatch, and existing editor/browser test failures)

Please review when convenient.

@changeset-bot

changeset-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d81e7a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added review/needs-review No maintainer or bot review yet area/admin size/XS labels Jun 16, 2026
@ahliweb

ahliweb commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Maintainers, please review this translation-only Indonesian locale fix when convenient. Thank you.

@github-actions

Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
packages/admin/src/locales/id/messages.po Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@pkg-pr-new

pkg-pr-new Bot commented Jun 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@1514

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@1514

@emdash-cms/auth-atproto

npm i https://pkg.pr.new/@emdash-cms/auth-atproto@1514

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@1514

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@1514

@emdash-cms/contentful-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/contentful-to-portable-text@1514

emdash

npm i https://pkg.pr.new/emdash@1514

create-emdash

npm i https://pkg.pr.new/create-emdash@1514

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@1514

@emdash-cms/plugin-cli

npm i https://pkg.pr.new/@emdash-cms/plugin-cli@1514

@emdash-cms/plugin-types

npm i https://pkg.pr.new/@emdash-cms/plugin-types@1514

@emdash-cms/registry-client

npm i https://pkg.pr.new/@emdash-cms/registry-client@1514

@emdash-cms/registry-lexicons

npm i https://pkg.pr.new/@emdash-cms/registry-lexicons@1514

@emdash-cms/sandbox-workerd

npm i https://pkg.pr.new/@emdash-cms/sandbox-workerd@1514

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@1514

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@1514

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@1514

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@1514

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@1514

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@1514

@emdash-cms/plugin-field-kit

npm i https://pkg.pr.new/@emdash-cms/plugin-field-kit@1514

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@1514

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@1514

commit: d81e7a0

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a tightly-scoped translation PR: it fills the previously empty Indonesian msgstr for the media detail URL: label. The choice of URL: as the target string is appropriate — “URL” is a common loanword/abbreviation in Indonesian tech UIs, and it matches the existing URL entry (without colon) in the same catalog. The change touches only the target PO file, and the source reference (packages/admin/src/components/MediaDetailPanel.tsx:193) and PO syntax are correct.

I checked the source component, the Indonesian catalog context, and the repository’s i18n guidelines. The only convention gap is the missing changeset. @emdash-cms/admin is a published package, and CONTRIBUTING.md calls for a changeset when a published package’s behavior changes. A recent sibling translation PR for the same locale (i18n(id): complete remaining admin translations, #1496) included one, so omitting it here is inconsistent and means this fix won’t trigger an admin release on its own.

Comment thread packages/admin/src/locales/id/messages.po
@github-actions github-actions Bot added review/awaiting-author Reviewed; waiting on the author to respond and removed review/needs-review No maintainer or bot review yet labels Jun 17, 2026
@ascorbic ascorbic merged commit ab3d1c0 into emdash-cms:main Jun 17, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/admin cla: signed review/awaiting-author Reviewed; waiting on the author to respond size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i18n(id): fix missing Indonesian translation for media detail URL label

2 participants