Skip to content

[bot] Fix #1269: Bug - Tags - "Edit Tag" interface not fully visible with large #s of locales #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascorbic merged 1 commit into from
Jun 12, 2026
+13 −3
Merged

[bot] Fix #1269: Bug - Tags - "Edit Tag" interface not fully visible with large #s of locales #1417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/fix-taxonomy-dialog-scroll.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"@emdash-cms/admin": patch
---

Fix taxonomy term edit dialog overflow with many locales (#1269)

Adds `max-h-[85vh] flex flex-col` to the `TermFormDialog` and makes its body
scrollable with `flex-1 overflow-y-auto`, keeping the header and footer pinned.
This prevents the Cancel/Update buttons from falling off-screen when the
Translations panel lists a large number of locales.
6 changes: 3 additions & 3 deletions packages/admin/src/components/TaxonomyManager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,8 +352,8 @@ function TermFormDialog({
}
}}
>
<Dialog className="p-6" size="lg">
<form onSubmit={handleSubmit}>
<Dialog className="p-6 max-h-[85vh] flex flex-col" size="lg">
<form onSubmit={handleSubmit} className="flex flex-col flex-1 min-h-0">
<div className="flex items-start justify-between gap-4 mb-4">
<div className="flex flex-col space-y-1.5">
<Dialog.Title className="text-lg font-semibold leading-none tracking-tight">
Expand Down Expand Up @@ -384,7 +384,7 @@ function TermFormDialog({
/>
</div>

<div className="space-y-4 py-4">
<div className="space-y-4 py-4 flex-1 overflow-y-auto -mx-1 px-1 min-h-0">
<Input
label={t`Name`}
value={label}
Expand Down
Loading