feat(i18n): add en-GB (British English) locale#1411
Open
memdigital wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: a10c795 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Scope checkThis PR changes 7,687 lines across 2 files. Large PRs are harder to review and more likely to be closed without review. If this scope is intentional, no action needed. A maintainer will review it. If not, please consider splitting this into smaller PRs. See CONTRIBUTING.md for contribution guidelines. |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA on #1411 |
Author
|
recheck |
Author
|
recheck |
2 similar comments
Author
|
recheck |
Author
|
recheck |
Adds an English (UK) locale catalogue: British spelling and morphology only (analyse, authorise, licence-the-noun, Align Centre, Search Engine Optimisation, etc.). ICU placeholders untouched. 19 strings differ from en; all other msgstr values mirror the source so coverage is 100%. Changeset included. Follows the documented locales.ts workflow; lingui compile passes.
memdigital
force-pushed
the
feat/en-gb-locale
branch
from
d803b63 to
6c62534
Compare
Author
|
recheck |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
ascorbic
previously approved these changes
Jun 11, 2026
Collaborator
|
The e2e tests are failing because strict matching fails when there are two languages that contain "English". Could you update the tests in the same PR to make them match the exact name? |
github-actions
Bot
added
review/approved
github-actions
Bot
added
review/needs-review
The en-GB locale adds a second option containing "English", so the substring match in the language switcher test now violates Playwright's strict mode. Match the exact accessible name instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an English (UK) locale, following the documented workflow in
locales.ts(entry added in the alphabetical slot, PO catalogue atsrc/locales/en-GB/messages.po, changeset included).Scope: spelling and morphology only. Terminology is deliberately untouched (e.g. "Trash" stays "Trash") so the locale stays uncontroversial - it's the same English, spelt British: analyse, authorise, organise, recognise, cancelled, centred, Align Centre, Search Engine Optimisation, licence (noun), etc.
en; every othermsgstrmirrors the source, so coverage is 100% and the locale shipsenabled: true.View the {license} licence on spdx.orgkeeps the{license}variable).Accept-LanguageBCP 47 resolution, so UK users get this with zero configuration.locales.ts.Happy to adjust the label wording ("English (UK)" vs "English (United Kingdom)") or the enabled default to your preference.
No linked issue - translation contribution.
Type of change
Checklist
pnpm typecheckpasses (note: a fresh clone shows pre-existing@emdash-cms/registry-clientresolution errors unrelated to this data-only change;pnpm locale:compilepasses with en-GB included)pnpm lintpasses (data-only change: onelocales.tsline + PO catalogue)pnpm testpasses (no behaviour change outside the new catalogue)pnpm formathas been run (Format CI check passes on this PR)messages.poinclusion is the change itself)@emdash-cms/admin: patch)AI-generated code disclosure
Screenshots / test output
Verified live on an Emdash 0.17.2 deployment: the language picker shows "English (UK)" (auto-selected for an en-GB browser via Accept-Language) and admin strings render with British spellings (e.g. Settings > SEO: "Search engine optimisation and verification").