Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy source annotations and labels #435

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Wieneo
Copy link

@Wieneo Wieneo commented Apr 15, 2024

This PR changes the reflector to copy annotations and labels from the source secret/configmap to the target.

@sando38
Copy link

sando38 commented Apr 16, 2024

That would be a great extension! Literally just have looked for the respective config in the repository.

@Wieneo
Copy link
Author

Wieneo commented Jun 4, 2024

@winromulus could you have a look at this? :)

@mircea-pavel-anton
Copy link

Hi, @winromulus! Sorry for the ping (again 😅 ). This is also crucial for me as I use this to mirror some configmaps containing CA secrets to my trust-manager namespace and then use a labelSelector to build up my CA Bundle. I would love for this to be added as it is quite blocking at the moment.

I can't create empty secrets/configmaps in the target namespace easily since this is meant to be used in a multi-cluster deployment and I don't have as much control over that

Copy link
Contributor

@winromulus winromulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the documentation as well and also this needs a flag that enables the functionality (it needs to be backwards compatible but also some people have deployments where the labels and annotaitons should NOT be copied because it crashes external tools).

@tomkukral
Copy link
Contributor

I'd love to have this feature available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants