Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE: Add more specific trigger event types #1300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gitKrystan
Copy link
Collaborator

@gitKrystan gitKrystan commented Dec 17, 2022

  1. Ensures any provided options are valid to initialize the event type for the provided eventType.
  2. If an actual element is provided, ensures the given event type is valid for that element. Only allows CustomEventInit options if not. (This falls apart if you use a string as the target argument though.)
  3. When you are typing, all of the possible eventType options are listed in the code completion dropdown. Unfortunately, this kind of falls apart when it gets to the options, as code completion doesn't seem to pick up anything past EventInit there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant