New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loadTests missing type #1186

Closed

simonihmig wants to merge 2 commits into emberjs:main from simonihmig:fix-loadtests-type

Contributor

simonihmig commented Feb 25, 2025

This is adding QUnitStartOptions.loadTests missing from ambient type declarations.

Interestingly, it was present in test-app/types/index.d.ts, but this was revealing the TS setup for the test-app was dysfunctional:

why would the test-app have type declarations duplicated that the addon should ship?
none of the test-app's files were .ts
its tsconfig.json was not in the test-app root, but in test-app/types, making it not being used at all

I decided to remove all TS setup from the test-app therefore. We can bring that back when introducing TS properly.

simonihmig added 2 commits

February 25, 2025 10:00


          Add QUnitStartOptions#loadTests type

5d91ee5


          Remove unused TS files in test-app

4eacaad

Contributor Author

simonihmig commented Feb 25, 2025

nvm, that was a misunderstanding with the loadTests type, it was still used in the app v2 blueprint, but the fix seems to remove it there!

simonihmig closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet