Upgrade default @typescript-eslint deps to v8 so CI benches projectService - #238
Merged
NullVoxPopuli merged 1 commit intoJul 6, 2026
Conversation
The Benchmark Comparison job installs the default devDependencies, and typescript-eslint v7's experimental projectService caps how many out-of-project files it accepts — .gts files never become in-project — so the project-mode bench feature-detects and drops projectService on CI. With v8 as the default, CI benches both project and projectService, the two modes typed linting actually runs under. The CI test matrix still covers ^6/^7/^8/canary via pnpm.overrides, which take precedence over these devDependencies. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
NullVoxPopuli
approved these changes
Jul 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Benchmark Comparison job installs the default devDependencies (
@typescript-eslint/*^7.1.0). v7's experimental projectService caps how many out-of-project files it accepts, and.gtsfiles never become in-project there, so the project-mode bench from #236 feature-detects the failure and drops theprojectServicescenario on CI — it currently only measuresprojectmode.With v8 as the default (resolves to 8.46.4 under the eslint 8 peer range), the bench runs both
projectandprojectService— the two modes typed linting actually runs under, and the ones typescript-eslint users hit issues with. Verified locally: warm-up now completes with both modes registered, full test suite passes (92/92).The CI test matrix is unaffected: it pins
^6/^7/^8/canaryper cell viapnpm.overrides, which take precedence over devDependencies.🤖 Generated with Claude Code