WIP: tracking branch for the website redesign RFC #868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use latest ember-styleguide with website-redesign branch
Fix styling of title and pencil
Sidemenu styling
bugfix/878 fix header icon
API docs styling tweaks
| @service router; | ||
| @service('project') projectService; | ||
|
|
||
| @controller('project-version.classes.class') classController; |
… and property and event routes
…tlify redirects. This is an issue when links within the app still reference ?anchor (perhaps from markdown). Our alternatives are to return to ?anchor or to add support to redirecting to #anchors to the Ember Router.
- Remove unit test of metrics tracking but add local metrics adapter to observe metrics tracking
… with the component from the guides in style - Now navigable by screen readers (tested with Voiceover) - Not 100% spec a11y but a big improvement over the previous search that was not usable at all by screen readers
Restore search to the website-redesign branch
…astboot and those that are not - Move to supported fork of ember-router-scroll
…e (through embroider) that uses a css optimizer that has a bug that strips media queries See embroider-build/embroider#1358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #803
fixes #607
fixes #621