Add Target Action Support deprecation guide #1410
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-deprecations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
||
| The `actions` hash on components, controllers, and routes, along with the `send` method, is deprecated. These APIs were primarily used with the now-deprecated `{{action}}` modifier and helper. | ||
|
|
||
| The modern approach is to use standard class methods decorated with the `@action` decorator, and to pass functions directly. |
There was a problem hiding this comment.
speaking of @action -- do we ever update deprecation guides? the recommendation will change once we actually get plain methods working for real
There was a problem hiding this comment.
Wouldn't we just deprecate @action at that point?
There was a problem hiding this comment.
we could -- tho that would be hugely disruptive across the ecosystem, so I think I'd want to wait a smidge.
There was huge resistance to deprecating @action here: emberjs/rfcs#1045 (which the RFC wasn't even proposing)
maybe that'll change once the alternative ships
Co-authored-by: NullVoxPopuli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: emberjs/rfcs#1041