fix: handle service name on multi-lines (strings with '+' operator)

[ludosch]

Got error on test file :

ERR tests/unit/features/components/xxx/component-test.js Transformation error (undefined does not match field "name": string of type Identifier)
Error: undefined does not match field "name": string of type Identifier
    at addParam (C:\Users\Public\app\nvm\v10.16.3\node_modules\ember-qunit-codemod\node_modules\ast-types\lib\types.js:565:23)
    at C:\Users\Public\app\nvm\v10.16.3\node_modules\ember-qunit-codemod\node_modules\ast-types\lib\types.js:594:21
    at Array.forEach (<anonymous>)
    at Function.identifier (C:\Users\Public\app\nvm\v10.16.3\node_modules\ember-qunit-codemod\node_modules\ast-types\lib\types.js:592:30)
    at NodePath.ctx.find.forEach.p (C:\Users\Public\app\nvm\v10.16.3\node_modules\ember-qunit-codemod\transforms\convert-module-for-to-setup-test/index.js:890:26)
    at __paths.forEach (C:\Users\Public\app\nvm\v10.16.3\node_modules\ember-qunit-codemod\node_modules\jscodeshift\src\Collection.js:77:36)
    at Array.forEach (<anonymous>)
    at Collection.forEach (C:\Users\Public\app\nvm\v10.16.3\node_modules\ember-qunit-codemod\node_modules\jscodeshift\src\Collection.js:76:18)
    at updateInjectCalls (C:\Users\Public\app\nvm\v10.16.3\node_modules\ember-qunit-codemod\transforms\convert-module-for-to-setup-test/index.js:879:8)
    at moduleInfo.moduleOptions.properties.forEach.property (C:\Users\Public\app\nvm\v10.16.3\node_modules\ember-qunit-codemod\transforms\convert-module-for-to-setup-test/index.js:403:13)

Reproduction

In test file, you have an inject service name cuted like this :

this.inject.service('service-with-a' + 
'-really-long-name', { as: 'service-with-a' +
 '-really-long-name' });

And run ember-qunit-codemod (no special arguments)

Change

This PR transforms cuted long services names in a single one, so there are no longer errors

[rwjblue]

I'm not sure that we should flatten things here (vs preserving the concatenation).

Happy to land either way (though I'd love to discuss the pros/cons of flattening), but will need some tests in order to move forward.

[ludosch]

@rwjblue : I added tests.
Yes, I think not flatten names is the best choice, but it's easiest to find services names after apply the codemod because they have the same name as attributes.

[ludosch]

@rwjblue : do you finally want a new version without flattening the names anyway ?