Skip to content

Conversation

@simonihmig
Copy link
Contributor

#159 first removed all the broccoli usage, then brought it back, I believe to bring back https://github.com/mixonic/ember-cli-deprecation-workflow/blob/master/vendor/ember-cli-deprecation-workflow/main.js. But actually the custom broccoli magic does not seem needed anymore, especially no need to bring in the config/deprecation-workflow.js file into the vendor tree anymore.

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@mixonic mixonic merged commit c16c4df into ember-cli:master May 21, 2024
@github-actions github-actions bot mentioned this pull request Jun 25, 2024
@mansona mansona added the bug label Jun 25, 2024
@simonihmig simonihmig deleted the cleanup-unused-vendor-magic branch July 19, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants