Support larger discovery characterisrics maximum buffer size #296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I just hit the panic here:
https://github.com/embassy-rs/nrf-softdevice/blob/master/nrf-softdevice/src/ble/gatt_client.rs#L179
And I can't see any way to increase the maximum number of characteristics when discovering services as it's hard-coded in
const DISC_CHARS_MAX
.The problem does not exist when I have an
att_mtu
of23
but when i increase theatt_mtu
to247
which i need for more throughput reading some of the GATT characteristics then the problem appears.In my case the packet contained 11 characteristics with an
att_mtu
of 247 so I have bumped it to 12 behind thediscovery-chars-12
feature flag (taking inspiration from theevt-max-size-256
feature flag - which I also need).I am tempted to do the same for
DISC_DESCS_MAX
but perhaps that's my OCD with consistency and symmetry so perhaps you can advise if you would prefer this or not?