stm32: fix hash after hmac, performance improvement #4554
+64
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running a hash after a hmac would hang, the CR.MODE bit isn't cleared by INIT. Test it by running the test twice.
For hash algorithm register update.
sha512 is only supported by hash_v3 and hash_v4, so add a feature for those chips.
chunks_exact produces better code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives a minor speedup for
Blockinghash update(). While writing a test I noticed that performing a hash after hmac failed, so that's fixed too here. And pulling on a piece of string, I used sha512 for the new test (for some variety), and that needed updates to metapac.