add selective tracing support to SpawnerTraceExt #4301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was added as a design alternative to #4300 |
kat-perez
force-pushed
the
feat-trace-selective-tracing
branch
2 times, most recently
from
be37b19 to
ed6e075
Compare
Add spawn_with_trace(), spawn_no_trace() and named variants to provide fine-grained control over task tracing. Supports both default tracing (rtos-trace) and selective tracing (rtos-trace-selective) modes while maintaining backward compatibility.
kat-perez
force-pushed
the
feat-trace-selective-tracing
branch
from
ed6e075 to
868eda6
Compare
lulf
reviewed
Jun 12, 2025
| @@ -94,6 +94,8 @@ pub(crate) struct TaskHeader { | |||
| #[cfg(feature = "trace")] | |||
| pub(crate) id: u32, | |||
| #[cfg(feature = "trace")] | |||
| pub(crate) trace_excluded: bool, | |||
There was a problem hiding this comment.
This should probably be guarded by a trace-mode-selective flag to save some space for programs not using it.
There was a problem hiding this comment.
thanks, added the trace-mode-selective flag in the latest update
kat-perez
force-pushed
the
feat-trace-selective-tracing
branch
3 times, most recently
from
512b09b to
fea17cf
Compare
- update rtos-trace selective to depend on trace-mode-selective - gate trace_excluded field behind trace-mode-selective instead of trace - reduce memory overhead when selective tracing is not needed
kat-perez
force-pushed
the
feat-trace-selective-tracing
branch
from
fea17cf to
508c33e
Compare
|
@lulf the ci/build job seemed to fail to error 137. Could I get a re-run for this job? |
|
bender run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add spawn_with_trace(), spawn_no_trace() and named variants to provide fine-grained control over task tracing. Supports both default tracing (rtos-trace) and selective tracing (rtos-trace-selective) modes while maintaining backward compatibility.