zerocopy_channel fixed channel and borrowed sender/receiver
#4299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows borrowing a Channel between multiple senders or receivers, but not simultaneously. It also makes it possible to send() or receive() on a Channel (by taking the Sender or Receiver temporarily). Only one borrow is allowed at a time, checked at runtime. .split() remains as it was previously, since it takes a mut reference.
This is an equivalent of zerocopy_channel::Channel with a fixed internal buffer, similar to embassy_sync::Channel. zero_copychannel::Channel and FixedChannel share a common ChannelInner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit implements a borrowed sender/receiver for
Channel. This allows sending from theChannelitself, and also could be an alternative to MPSC such as in #2322. Currently there isn't any asyncsender()/receiver()equivalent, since that'd need a bounded number of wakers and seems like complication.The extra bools in the struct don't add any size, the only overhead will be some bit flips on construction/drop.
The second commit allows having a
FixedChannelwith local storage. I think the use ofUnsafeCellis safe, but it would be good if someone with moreunsafeexperience could take a look over it.new_cloned()name is a bit arbitrary.