Return json rpc when sending SSE events in streaming #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafael Gutiérrez <[email protected]>
abadongutierrez
commented
Aug 10, 2025
| * Shuts down the streaming handler | ||
| */ | ||
| fun shutdown() { | ||
| logger.info("Shutting down, closing {} active streams", activeStreams.size) |
Contributor
Author
There was a problem hiding this comment.
Code here was suggested by AI but, imho, looks good
Contributor
There was a problem hiding this comment.
@abadongutierrez
could you please consider adding unit tests. does A2AWebIntegrationTest fully cover added behavior? hank you
Following spec https://a2a-protocol.org/latest/specification/#93-streaming-task-execution-sse Signed-off-by: Rafael Gutiérrez <[email protected]>
Contributor
|
Is this still active? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.