Create the Initial hub #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emanuelmch
force-pushed
the
hub
branch
3 times, most recently
from
679eb36 to
7619b4b
Compare
emanuelmch
force-pushed
the
hub
branch
2 times, most recently
from
ce5e27c to
f0ac178
Compare
emanuelmch
force-pushed
the
hub
branch
4 times, most recently
from
a0b0b46 to
a27d769
Compare
Target SDK Version to 29 AGP to 4.0.0-alpha03 Gradle to 6.0 Kotlin to 1.3.60-eap-25 Reaktive to HEAD
I had originally added the `relaxed = true` bit to make the mocking easier, but testing it now shows it's not necessary. I don't know whether it wasn't necessary to begin with or I just hadn't thought of trying it one more time back then, but one way or another, it's not needed now.
I hate the `(!bool)` style with a passion, but I'm not against the `(bool.not())` one
By coincidence, this wasn't triggering a behavior bug, but I discovered it while working on new stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this officially transitions from catbox to toybox