[WIP] Hangman #15
Open
[WIP] Hangman #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do the "is it solved?" check earlier in the process, so we can also finish earlier. To be more precise, we're now need to go one level less deep than before (except for trivial cases, where we're still just as good).
Also added a helper FileReader class
emanuelmch
force-pushed
the
arbitrary_container
branch
3 times, most recently
from
80db9ef to
3cbdf5d
Compare
herculesjr
reviewed
Sep 19, 2020
| using namespace Hangman; | ||
|
|
||
| char AlphaOrderPlayerSession::guess() { | ||
| auto letters = {'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', |
Collaborator
There was a problem hiding this comment.
how about non-ASCII letters?
|
|
||
| for (const auto &word : repository.words()) { | ||
| for (auto letter : word) { | ||
| assert(letter >= 'A' && letter <= 'Z'); |
Collaborator
There was a problem hiding this comment.
this might break for non-ASCII characters
| using namespace Puzzles; | ||
|
|
||
| std::vector<std::string> WordRepository::words() { | ||
| if (_words.empty()) { |
Collaborator
There was a problem hiding this comment.
how about changing it to an early return?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Hangman game + players! Still a WIP, though.