Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL Fluid template #208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RTL Fluid template #208

wants to merge 1 commit into from

Conversation

ahangarha
Copy link

I just made a new template for RTL (right to left) languages such as Persian, Arabic, Urdu,... based on Fluid template.

Please take a look on it and if it is fine, I continue working on making RTL version of other templates as well.

@TedGoas
Copy link
Collaborator

TedGoas commented Feb 5, 2019

@ahangarha Hey thanks for thinking about this. RTL is definitely something I'd like to support, but I have another idea of how to do it. Would love your thoughts.

I reviewed the first template you updated and from what I can tell, the change from the regular templates would be pretty minimal. Add a direction: rtl !important; to the CSS reset is what I saw, is there anything else I missed?

If possible, I'd rather not go from supporting three templates to six for a one or two line change. Maintaining the three templates is a manual process, so I'd love to keep the number of moving parts to a minimum.

Instead of adding more templates, I wonder if we could add instructions on how to change each template to RTL in the documentation. Perhaps something like this?
screen shot 2019-02-05 at 11 27 26 am

@ahangarha
Copy link
Author

ahangarha commented Feb 5, 2019 via email

@TedGoas
Copy link
Collaborator

TedGoas commented Mar 12, 2019

@ahangarha Howdy, any update on this?

@ahangarha
Copy link
Author

Didn't find time to work on it. Keep the issue open. I will work for sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants