Unmark the temporary buffer for preview as modified #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two annoying problems. - When `set-auto-mode` is called with a buffer marked as modified, some minor modes that conditionally call `revert-buffer` result in generating a user prompt while navigating through helm candidates. `editorconfig-mode` is one of such modes. `editorconfig-apply` is called via `change-major-mode-after-body-hook` and tries to enforce the coding system specified by the project via `revert-buffer-with-coding-system`, which generates a yes-or-no-p prompt asking "Revert buffer from file <filename>?". - Persistent undo history for the file is affected and broken when using packages like `undohist` and `undo-fu-session`.
|
Is there anyone who can merge this? /ping @jcs090218 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two annoying problems.
When
set-auto-modeis called with a buffer marked as modified, some minor modes that conditionally callrevert-bufferresult in generating a user prompt while navigating through helm candidates.editorconfig-modeis one of such modes.editorconfig-applyis called viachange-major-mode-after-body-hookand tries to enforce the coding system specified by the project viarevert-buffer-with-coding-system, which generates a yes-or-no-p prompt asking "Revert buffer from file ?".Persistent undo history for the file is affected and broken when using packages like
undohistandundo-fu-session.