Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(Makefile): Update eask's commands #82

Merged
merged 3 commits into from
Nov 2, 2022
Merged

tests(Makefile): Update eask's commands #82

merged 3 commits into from
Nov 2, 2022

Conversation

jcs090218
Copy link
Member

This fixes CI.

@kurnevsky
Copy link
Member

Thanks. It seems it didn't fix the CI. Is there anything left to do? :)

@jcs090218
Copy link
Member Author

The error is:

lsp-metals-treeview.el:338:1:Error: Wrong number of arguments: (1 . 1), 0

Due to #81. It's an issue from upstream, Alexander-Miller/treemacs#982. Nothing I can do for the issue. (Not in this PR)

Hence, nothing left to do.

@kurnevsky
Copy link
Member

Ah, ok, thanks. I got confused by a lot of Can't find library errors :)

@jcs090218
Copy link
Member Author

Ah, ok, thanks. I got confused by a lot of Can't find library errors :)

Ah, yes. It's discussed in emacs-eask/cli#11. I guess it's a known issue from Eask. Sorry for the confusion!

@kurnevsky
Copy link
Member

It doesn't make things worse, so I'll merge this. Thanks.

@kurnevsky kurnevsky merged commit a1d0619 into emacs-lsp:master Nov 2, 2022
@jcs090218 jcs090218 deleted the tests/update-eask-command branch November 2, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants