Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support real GDB #791

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Support real GDB #791

merged 1 commit into from
Apr 28, 2024

Conversation

daym
Copy link
Contributor

@daym daym commented Apr 27, 2024 •
edited
Loading

Fixes #790.

@daym daym force-pushed the gdb-14 branch 14 times, most recently from 96783f5 to 2ad8821 Compare April 27, 2024 23:55
@daym daym changed the title dap-cpptools: Prefer gdb if new enough and debugger to use was not cu… lsp-rust: Prefer gdb if new enough and debugger to use was not cu… Apr 28, 2024
@daym daym changed the title lsp-rust: Prefer gdb if new enough and debugger to use was not cu… lsp-rust: Support actual GDB Apr 28, 2024
@daym daym changed the title lsp-rust: Support actual GDB Support real GDB Apr 28, 2024
jcs090218
jcs090218 reviewed Apr 28, 2024
View reviewed changes
Copy link
Member

@jcs090218 jcs090218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the CHANGELOG too?

dap-gdb.el Outdated Show resolved Hide resolved
@jcs090218
Copy link
Member

There is a compile error:

dap-gdb.el:30:1:Error: Wrong number of arguments: (3 . 3), 2

@daym
Copy link
Contributor Author

daym commented Apr 28, 2024 •
edited
Loading

Ok, updated CHANGELOG, fixed a typo and successfully tested for a while with lsp-rust.

@daym daym requested a review from jcs090218 April 28, 2024 18:30
@jcs090218 jcs090218 merged commit 65ac9db into emacs-lsp:master Apr 28, 2024
10 of 12 checks passed
@jcs090218
Copy link
Member

Thank you!

@daym daym deleted the gdb-14 branch April 29, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcs090218 jcs090218 jcs090218 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GDB 14 supports DAP natively
2 participants
@daym @jcs090218