Skip to content

Fix src block cache #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix src block cache #598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
830095e
Fixup for `Refactor source block caching`
tmurph Sep 3, 2025
1c7c507
Fix source block caching.
tmurph Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions jupyter-org-client.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,11 +618,11 @@ source block, return non-nil. Otherwise, when `point' is not
inside a Jupyter src-block, return nil."
(unless jupyter-org--src-block-cache
(setq jupyter-org--src-block-cache
(list (list 'invalid nil (make-marker)
(let ((end (make-marker)))
;; Move the end marker when text is inserted
(set-marker-insertion-type end t)
end)))))
(list 'invalid nil (make-marker)
(let ((end (make-marker)))
;; Move the end marker when text is inserted
(set-marker-insertion-type end t)
end))))
(if (org-in-src-block-p 'inside)
(or (jupyter-org--at-cached-src-block-p)
(when-let* ((el (org-element-at-point))
Expand Down
6 changes: 3 additions & 3 deletions test/jupyter-test.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2170,10 +2170,10 @@ Image(filename='%s', width=300)" file)
(forward-line)
(end-of-line)
(should-not jupyter-org--src-block-cache)
(should-not (jupyter-org--same-src-block-p))
(jupyter-org--set-current-src-block)
(should-not (jupyter-org--at-cached-src-block-p))
(jupyter-org--set-src-block-cache)
(should jupyter-org--src-block-cache)
(should (jupyter-org--same-src-block-p))
(should (jupyter-org--at-cached-src-block-p))
(cl-destructuring-bind (params beg end)
jupyter-org--src-block-cache
(should (equal (alist-get :session params) jupyter-org-test-session))
Expand Down