Typescript fixes & minor cleanup #894
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔧 (package.json): add pretest:node script to ensure build before tests ♻️ (response.test.ts): remove unnecessary ts-expect-error comments ♻️ (elysia.test.ts): remove unnecessary ts-expect-error comments ♻️ (handle-error.test.ts): remove forceErrorEncapsulation option ♻️ (modules.test.ts): remove unused eslint-disable comment ♻️ (error.test.ts): remove unused import 'error' ♻️ (utils.ts): remove unnecessary empty object in WebSocket constructor
…ing issues with tests
…r headers.keys() and headers.getAll()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ts-ignoreand@ts-expect-errorsstringas the type. This also fixes the type errors in the tests.Checktest withCheck - Castthat checks the non encoded versionCheck - Stringtest which checks the encoded versionunknownwithstring | Blobto correctly fix the typesforceErrorEncapsulation: truefrom thehandle-errortest as this option is no longer validerrortest check for thepathin the error to narrow the type as ValidationError can return two very different types.@ts-expect-errorin theresponsetest. Unsure why, code looks spec correct.DOMandDOM.Iterableto thetsconfig.json. These are required forheaders.keys()(DOM) andheaders.getAll()(DOM.Iterable). Do note though thatheaders.getAll()has been removed from the spec and is deprecated. It doesn't exist in the node only types anymore.All tests pass.
Hope this helps, I wanted to try work on a few things I've needed but had to fix a few types in the process so thought I'd submit them separately first.