Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change RDNN #12

Merged
merged 11 commits into from
Oct 15, 2024
Merged

Change RDNN #12

merged 11 commits into from
Oct 15, 2024

Conversation

alainm23
Copy link
Contributor

@alainm23 alainm23 commented Oct 14, 2024

Fixed #4

@alainm23 alainm23 marked this pull request as draft October 14, 2024 16:50
@alainm23 alainm23 marked this pull request as ready for review October 14, 2024 17:04
@dar5hak
Copy link

dar5hak commented Oct 14, 2024

It might be a good idea to use a hyphen (ellie-commons) instead of an underscore, because app-generator has a hyphen, which is more common anyway.

Additionally, you'll need to rename the pot file, the screenshot file, etc.

@alainm23
Copy link
Contributor Author

According to the official doc, there is a detail.

https://docs.flatpak.org/en/latest/conventions.html#application-ids

@dar5hak
Copy link

dar5hak commented Oct 14, 2024

Ah, my bad.

data/app-generator.appdata.xml.in Outdated Show resolved Hide resolved
data/app-generator.appdata.xml.in Outdated Show resolved Hide resolved
data/app-generator.appdata.xml.in Outdated Show resolved Hide resolved
@alainm23 alainm23 requested a review from ryonakano October 15, 2024 10:54
@ryonakano
Copy link
Member

Maybe we may want to replace the last occurrence of elementary-community while we're here

[ryo@b760m ~/work/ellie-commons/app-generator (feat/RDNN =)]$ git grepn elementary-community
README.md:9:![Screenshot](https://raw.githubusercontent.com/elementary-community/app-generator/refs/heads/main/data/io.github.ellie_commons.app-generator.png)
[ryo@b760m ~/work/ellie-commons/app-generator (feat/RDNN =)]$

README.md Outdated Show resolved Hide resolved
Co-authored-by: Ryo Nakano <[email protected]>
@alainm23 alainm23 requested a review from ryonakano October 15, 2024 11:14
Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for this!

@alainm23
Copy link
Contributor Author

Thank you very much for your time

@alainm23 alainm23 merged commit a1fd023 into main Oct 15, 2024
3 checks passed
@ryonakano ryonakano deleted the feat/RDNN branch October 15, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generated Metainfo contains deprecated developer_name tag
3 participants