Feat: integrate user account management and refine UI iconography with SVG presets - #62
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Circuit-Overtime
left a comment
There was a problem hiding this comment.
Blocking findings:
-
components/navbar.tsx:38-64initializes every visitor as logged in and treats a mutable localStorage flag as authentication.app/login/page.tsx:10-16andapp/register/page.tsx:10-16set that flag without any Elixpo Login/session validation, while the UI labels the action GitHub sign-in. This exposes authenticated navigation and lets anyone impersonate the hardcoded user. Please integrate the actual Elixpo Login/session boundary, or keep these routes explicitly unauthenticated placeholders that cannot grant access. -
app/settings/page.tsx:8-16,71-76hardcodes another person’s email/GitHub identity and reports successful saves/disconnect actions without persistence.app/profile/[username]/page.tsx:7-18fabricates stats and contribution records for every arbitrary username. These user-facing pages must load authenticated/real data or present neutral, clearly labelled empty states. -
The added hierarchy conflicts with the agreed frontend route model (
/contests,/contests/[slug]/projects,/contests/[slug]/leaderboard,/u/[handle],/dashboard/rewards) by adding top-level/projects,/leaderboard,/profile/[username], and/wallet. Please align the routes before these links become public contracts. -
The branch fails
git diff --checkin multiple added files. CI also currently fails because.github/workflows/biome.ymlinvokes a missing./biome.sh; that repository-level CI defect must be resolved before this can be considered green.
I could not run typecheck/build in this workspace because the runner currently has no Node/npm executable, so those checks also remain unverified.
|
[CHANGE LOG] 📋 Changelog updated for PR #62. View changelog |
Overview
This Pull Request completes the user account workflow by introducing core profile and authentication modules and upgrading the global iconography system. Emojis throughout key routes have been replaced with modern, scalable SVG presets to align with professional design standards.
Key Implementations
User Account & Authentication Views
/profile/[username]): Renders contributor-specific metrics including merged pull requests, streak statistics, and specialized contribution badges./dashboard): Provides active tracking of claimed issues, repository integrations, and unified switches for managing contest workflows./wallet): Displays payout tallies (earned, unpaid, and pending), linked payment methods (Wise), and past transaction wire ledgers./settings): Facilitates updates to user metadata (username, email) and OAuth credentials configuration./login,/register): Simplifies onboarding with simulated single sign-on (SSO) loops.