Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Postgres adapter docs #654

Merged
merged 4 commits into from
Feb 21, 2025

Conversation

greg-rychlewski
Copy link
Member

Ecto.Adapters.Postgres.extensions() looks to me like a relic from the past that is no longer applicable. But please let me know if I'm missing something.

@josevalim
Copy link
Member

It is a relic from the past but we decided to keep in case we need to add extensions in the future. Perhaps we keep the function public but we no longer refer to it in the docs?

@greg-rychlewski
Copy link
Member Author

Ah got it! Done.

For some context, I was reading this thread here and trying to think of how to help clarify things and I noticed some people thought Duration couldn't work without it: https://elixirforum.com/t/difficulty-employing-duration-to-postgresql-interval-with-solution/67990

@greg-rychlewski
Copy link
Member Author

Maybe I should add a note to the function doc that says there are currently no Ecto defined extensions but there may be in the future?

@greg-rychlewski greg-rychlewski merged commit d0eb7fc into elixir-ecto:master Feb 21, 2025
11 checks passed
@greg-rychlewski greg-rychlewski deleted the doc_update branch February 21, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants