Provide function group descriptions in Ecto.Repo
#4643
Merged
+21
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ecto.Repo.all_running/0
to "Process API" group.I was reading the docs for
update_all
and was surprised to find it under "Query API", while other update-related callback functions are part of the "Schema API".I understand "Query API" is for all APIs related to reading from the database, and "Schema API" for writing. In that interpretation,load
,reload
,reload!
, andpreload
would also fit better within Query API.Update: the groups are based on the data they operate on, see #4643 (comment).
The
all_running/0
function was the only one outside any group, but it fits with the "Process API" group.