Change introduction doc grouping #4583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The introduction doc grouping reads as a step-by-step tutorial for creating the `friends` example. The Embedded Schema docs being included can be confusing for someone using the bottom nav, since they would get moved from the friends example to an unrelated user profile example. It seems to be more fitting as a how-to. I also moved out the testing docs for similar reasons. In Phoenix, testing has its own section, so I did the same for Ecto (since the testing documentation is disconnected from `friends`.
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduction doc grouping reads as a step-by-step tutorial for creating the
friendsexample.The Embedded Schema docs being included can be confusing for someone using the bottom nav, since they would get moved from the friends example to an unrelated user profile example for embedded schemas. It seems to be more fitting as a how-to.
I also moved out the testing docs for similar reasons. In Phoenix, testing has its own section, so I did the same for Ecto (since the testing documentation is disconnected from
friends.