feat(archive): add password visibility toggle#220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a visibility toggle to encrypted archive password prompts.
Passwords still start hidden, but the prompt now supports
Alt+Vand a inline eye button to show or hide the current input. The prompt also keeps the password field usable in short terminal windows by preserving the input row before showing the footer hint.Testing
Verified with:
cargo fmt --checkcargo test --locked --test architecture_guardrailscargo clippy --locked --all-targets -- -D warningscargo test --lockedRUSTDOCFLAGS="-D warnings" cargo doc --locked --no-depsDocumentation and Changelog
CHANGELOG.mdentry for user-visible changes