fix(ui): improve edit overlay list sizing#219
Merged
Conversation
MiguelRegueiro
force-pushed
the
fix-edit-overlay-list-sizing
branch
from
d70ff67 to
781cd68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve list sizing in create, bulk rename, and archive creation overlays.
The overlays now show more rows before scrolling, shrink cleanly on short terminals, keep the active row visible, and use the shared overlay scrollbar styling.
Testing
Verified with:
cargo fmt --checkcargo checkcargo test edit_overlay_visible_rows_caps_and_shrinks_to_terminal_height --libcargo test overlay_scrolls_to_keep --libcargo testDocumentation and Changelog
CHANGELOG.mdentry for user-visible changes