feat(core): implement Context::send in the builder-like manner
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerodono
force-pushed
the
feat/send-builder-poc
branch
2 times, most recently
from
036421a to
a0c4b86
Compare
nerodono
force-pushed
the
feat/send-builder-poc
branch
from
a0c4b86 to
86e21b7
Compare
nerodono
commented
Feb 23, 2025
| /// ``` | ||
| /// | ||
| /// [inter-group routing]: https://actoromicon.rs/ch04-01-routing.html | ||
| pub fn try_send<M: Message>(&self, message: M) -> Result<(), TrySendError<M>> { |
There was a problem hiding this comment.
Maybe deprecate those methods in favor of just send?
nerodono
commented
Feb 23, 2025
| use tracing::trace; | ||
|
|
||
| use crate::{ | ||
| context::{addrs_with_envelope, e2m, DUMPER}, |
There was a problem hiding this comment.
I guess some of this functionality now should be here, but I'm quite reluctant to move more code more at this state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding behavior settings for
Context::sendcould be annoying, we already have functions likeunbounded_send,send,send_to,unbounded_send_to,try_send,try_send_toand so on. With turningsendinto builder, we could achieve having only one function in theContext:Context::send, actions performed on that builder could be divided in two categoriesOutcome
Function which finishes building of envelope and sends it, such as
ctx.send(..).try_()- try send without waiting for available place in the mailboxctx.send(..).unbounded()- send envelope unconditionallyctx.send(..).await- wait for place in the destination mailbox and sendParameters
.to(..)- destinationMoreover, we could elide
requestandrequest_tofunctions as well, but it requires more thought though, sincectx.send(..).resolve().awaitlooks nice, butctx.send(..).all().awaitseems confusing (Maybe unifyingsendandrequestinterfaces is quite unfortunate?)