feat(core): use available memory as a trigger for OOM shutdown #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`avail < total * (1 - ratio)` threshold is now used instead of old `used > total * ratio` to shutdown a service when tracking memory usage. Additionally, total memory in bytes, and used/available memory as percentages of total memory are now being logged on OOM.
loyd
requested changes
Jan 31, 2024
White-Oak
force-pushed
the
oom-based-on-available-memory
branch
2 times, most recently
from
5097b7d to
a88816e
Compare
White-Oak
force-pushed
the
oom-based-on-available-memory
branch
from
a88816e to
7300477
Compare
loyd
approved these changes
Feb 1, 2024
White-Oak
force-pushed
the
oom-based-on-available-memory
branch
from
7300477 to
95197be
Compare
White-Oak
force-pushed
the
oom-based-on-available-memory
branch
from
95197be to
bd4a564
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avail < total * (1 - ratio)threshold is now used instead of oldused > total * ratioto shutdown a service when tracking memory usage.Additionally, total memory in bytes, and used/available memory as percentages of total memory are now being logged on OOM.