Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump node to v22, remove form data and fetch polyfills #134

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

talentlessguy
Copy link

@talentlessguy talentlessguy commented Jan 19, 2025

This pull request upgrade minimum supported Node.js 22 and as a result:

  • drops 4 direct and 21 deps in total
  • makes the code smaller, while not changing any of the external APIs
  • 19.48% smaller install size

Node 15 has been EOL since 2021, while Node 22 is the latest LTS, which has first-class fetch support (since node 18) as well as native FormData support. Both Vercel Edge runtime and Cloudflare support fetch and FormData first-class, so those polyfills are no longer necessary.

@louisjoecodes
Copy link
Collaborator

Thank you!

@@ -45,5 +39,9 @@
"path": false,
"command-exists": false,
"execa": false
},
"packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was added by corepack, I can undo if needed

@louisjoecodes
Copy link
Collaborator

Shared this with the Fern team who will include some of these ideas upstream.
cc: @dsinghvi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants