Skip to content

OperatingSystemView: assume updates are atomic #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danirabbit wants to merge 3 commits into
base: main
Choose a base branch
from
Open

OperatingSystemView: assume updates are atomic #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33bf58c
OperatingSystemView: assume updates are atomic
danirabbit Sep 24, 2026
8c6e512
Merge branch 'main' into danirabbit/operatingsystemview-assumeatomicu…
danirabbit Sep 30, 2026
fc33f46
Merge branch 'main' into danirabbit/operatingsystemview-assumeatomicu…
zeebok Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 13 additions & 31 deletions src/Views/OperatingSystemView.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ public class About.OperatingSystemView : Gtk.Box {

private File? logo_file;
private Adw.Avatar? logo;
private Gtk.StringList packages;
private SystemUpdate? update_proxy = null;
private SystemUpdate.CurrentState? current_state = null;
private Gtk.Grid software_grid;
Expand Down Expand Up @@ -174,8 +173,6 @@ public class About.OperatingSystemView : Gtk.Box {
kernel_version_label.add_css_class (Granite.CssClass.SMALL);
kernel_version_label.add_css_class (Granite.CssClass.DIM);

packages = new Gtk.StringList (null);

updates_image = new Gtk.Image () {
icon_size = LARGE
};
Expand Down Expand Up @@ -522,7 +519,7 @@ public class About.OperatingSystemView : Gtk.Box {
}

update_progress_revealer.reveal_child = false;
details_button_revealer.reveal_child = current_state.state == AVAILABLE || current_state.state == ERROR;
details_button_revealer.reveal_child = current_state.state == ERROR;

switch (current_state.state) {
case UP_TO_DATE:
Expand Down Expand Up @@ -556,18 +553,11 @@ public class About.OperatingSystemView : Gtk.Box {

try {
var details = yield update_proxy.get_update_details ();
updates_description.label = dngettext (
GETTEXT_PACKAGE,
"%i update available (%s)",
"%i updates available (%s)",
details.packages.length
).printf (details.packages.length, GLib.format_size (details.size));
updates_description.label = GLib.format_size (details.size);

if (Pk.Info.SECURITY in details.info) {
updates_image.icon_name = "software-update-urgent";
}

packages.splice (0, packages.get_n_items (), details.packages);
} catch (Error e) {
updates_description.label = _("Unable to determine number of updates");
warning ("Failed to get updates list from backend: %s", e.message);
Expand Down Expand Up @@ -622,27 +612,19 @@ public class About.OperatingSystemView : Gtk.Box {
return;
}

if (current_state.state == ERROR) {
var message_dialog = new Granite.MessageDialog (
_("Failed to download updates"),
_("This may have been caused by sideloaded or manually compiled software, a third-party software source, or a package manager error. Manually refreshing updates may resolve the issue."),
new ThemedIcon ("dialog-error")
) {
transient_for = (Gtk.Window) get_root (),
modal = true
};

message_dialog.show_error_details (current_state.message);
var message_dialog = new Granite.MessageDialog (
_("Failed to download updates"),
_("This may have been caused by sideloaded or manually compiled software, a third-party software source, or a package manager error. Manually refreshing updates may resolve the issue."),
new ThemedIcon ("dialog-error")
) {
transient_for = (Gtk.Window) get_root (),
modal = true
};

message_dialog.response.connect (message_dialog.destroy);
message_dialog.present ();
return;
}
message_dialog.show_error_details (current_state.message);

var details_dialog = new UpdateDetailsDialog (packages) {
transient_for = (Gtk.Window) get_root ()
};
details_dialog.present ();
message_dialog.response.connect (message_dialog.destroy);
message_dialog.present ();
}

private async void refresh_clicked () {
Expand Down
73 changes: 0 additions & 73 deletions src/Widgets/UpdateDetailsDialog.vala
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions src/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ plug_files = files(
'Views/HardwareView.vala',
'Views/OperatingSystemView.vala',
'Widgets/FirmwareUpdateRow.vala',
'Widgets' / 'DriverRow.vala',
'Widgets' / 'UpdateDetailsDialog.vala'
'Widgets' / 'DriverRow.vala'
)

switchboard_dep = dependency('switchboard-3')
Expand Down
Loading