Fix mypy errors on Twisted 24.11.0 #17998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolveHostName wanted an instance of a type. We also had to switch from provider to implementer, as the latter implies that any instances implement the given interface. Fixed the following error: synapse/http/client.py:243: error: Argument 1 to "resolveHostName" of "IHostnameResolver" has incompatible type "type[EndpointReceiver]"; expected "IResolutionReceiver" [arg-type]
mypy would not accept passing a **kwargs to `HostnameEndpoint`. Resolves the following errors: synapse/http/proxyagent.py:385: error: Argument 4 to "HostnameEndpoint" has incompatible type "**dict[str, object]"; expected "float" [arg-type] synapse/http/proxyagent.py:385: error: Argument 4 to "HostnameEndpoint" has incompatible type "**dict[str, object]"; expected "Union[bytes, str, tuple[Union[bytes, str], int], None]" [arg-type] synapse/http/proxyagent.py:385: error: Argument 4 to "HostnameEndpoint" has incompatible type "**dict[str, object]"; expected "Optional[float]" [arg-type]
`._hostStr` was replaced with `._hostText` in twisted/twisted#12351 Resolves the following errors: tests/http/test_proxyagent.py:857: error: "HostnameEndpoint" has no attribute "_hostStr" [attr-defined] tests/http/test_proxyagent.py:869: error: "HostnameEndpoint" has no attribute "_hostStr" [attr-defined]
just mypy being particular about changing the type of an already-defined variable. Resolves the following mypy errors: synapse/http/replicationagent.py:92: error: Incompatible types in assignment (expression has type "_WrapperEndpoint", variable has type "HostnameEndpoint") [assignment] synapse/http/proxyagent.py:394: error: Incompatible types in assignment (expression has type "_WrapperEndpoint", variable has type "HostnameEndpoint") [assignment]
anoadragon453
changed the title
erikjohnston
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes various
mypyerrors associated with Twisted24.11.0.Hopefully addresses #17075, though I've yet to test against
trunk.Changes should be compatible with our currently pinned Twisted version of
24.7.0.