Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Python 3.8 leftovers #17967

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Conversation

V02460
Copy link
Contributor

@V02460 V02460 commented Nov 27, 2024

Some small cleanups after Python3.8 became EOL.

  • Move some type imports from typing_extensions to typing
  • Remove the abi3-py38 feature from pyo3

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@V02460 V02460 requested a review from a team as a code owner November 27, 2024 00:18
rust/Cargo.toml Show resolved Hide resolved
changelog.d/17967.misc Outdated Show resolved Hide resolved
@V02460
Copy link
Contributor Author

V02460 commented Dec 6, 2024

I added the abi3-py39 option, so this PR can be merged. Should I find out it is better omitted, I’ll open a new PR.

@V02460 V02460 requested a review from sandhose December 6, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants