Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the project to use Xcode 16. #3303

Draft
wants to merge 15 commits into
base: develop
Choose a base branch
from
Draft

Update the project to use Xcode 16. #3303

wants to merge 15 commits into from

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Sep 18, 2024

Draft for now,

  • Fastlane uses Xcode 16
  • Unit Tests
    • Pass locally
    • Pass on CI
  • Preview Tests
    • Pass locally
    • Pass on CI
  • UI Tests
    • Pass locally
    • Pass on CI
  • Integration Tests
    • Pass locally
    • Pass on CI
  • Xcode Cloud uses Xcode 16

Bugs

@pixlwave pixlwave requested a review from a team as a code owner September 18, 2024 15:18
@pixlwave pixlwave requested review from stefanceriu and removed request for a team September 18, 2024 15:18
@pixlwave pixlwave marked this pull request as draft September 18, 2024 15:18
@pixlwave pixlwave removed the request for review from stefanceriu September 18, 2024 15:18
Copy link

github-actions bot commented Sep 18, 2024

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 6169664

Copy link

codecov bot commented Sep 18, 2024

❌ 9 Tests Failed:

Tests completed Failed Passed Skipped
873 9 864 0
View the top 2 failed tests by shortest run time
RoomScreenUITests testTimelineLayoutAtTop()
Stack Traces | 98.5s run time
failed - Snapshot "UI" does not match reference.

@−
"file:.../__Snapshots__/Application/roomLayoutTop-iPhone-16-en-GB.UI.png"
@+
"file:.../__FailedScreenshots__/Application/roomLayoutTop-iPhone-16-en-GB.UI.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.4970703 is less than required 0.99
The lowest perceptual color precision 0.148125 is less than required 0.98 (.../UITests/Sources/Application.swift:88)
CreateRoomScreenUITests testLanding()
Stack Traces | 102s run time
Failed to launch <XCUIApplicationImpl: 0x313e71950 io.element.elementx at .../Variant-ASan-UBSan/Debug-iphonesimulator/ElementX.app> via Xcode: Timed out while launching application via Xcode. (.../UITests/Sources/Application.swift:29)
View the full list of 1 ❄️ flaky tests
UserSessionScreenTests testElementCall()

Flake rate in main: 18.52% (Passed 22 times, Failed 5 times)

Stack Traces | 59.1s run time
XCTAssertTrue failed (.../UITests/Sources/UserSessionScreenTests.swift:47)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@pixlwave pixlwave added the pr-build for changes related to build, tools, CI/CD label Sep 19, 2024
Copy link

sonarcloud bot commented Sep 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build for changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant