Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore m.3pid_changes for Identity service 3PID changes #28375

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Ignore m.3pid_changes for Identity service 3PID changes #28375

merged 1 commit into from
Nov 6, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Nov 4, 2024

Fixes #28355

@t3chguy t3chguy self-assigned this Nov 4, 2024
@t3chguy t3chguy marked this pull request as ready for review November 4, 2024 17:38
@t3chguy t3chguy requested a review from a team as a code owner November 4, 2024 17:38
robintown
robintown reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I understand why the m.3pid_changes capability and the act of adding or removing 3PIDs would be unrelated. Why was the check there previously?

@t3chguy
Copy link
Member Author

t3chguy commented Nov 4, 2024

Copy-pastad from the HS 3PID management code. The HS /capabilities API does not speak for your IS

@t3chguy t3chguy added this pull request to the merge queue Nov 6, 2024
Merged via the queue into develop with commit 88c72a1 Nov 6, 2024
45 checks passed
@t3chguy t3chguy deleted the t3chguy/fix/28355 branch November 6, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robintown robintown robintown approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Element doesn't let users bind their emails with identity servers if the m.3pid_changes capability is off
2 participants
@t3chguy @robintown