Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Jest test: "AddRemoveThreepids › should add a phone number" #28048

Open
richvdh opened this issue Sep 13, 2024 · 2 comments
Open

Flaky Jest test: "AddRemoveThreepids › should add a phone number" #28048

richvdh opened this issue Sep 13, 2024 · 2 comments
Labels
A-Developer-Experience O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Flaky-Test A test is raising false alarms

Comments

@richvdh
Copy link
Member

richvdh commented Sep 13, 2024 

  FAIL  test/components/views/settings/AddRemoveThreepids-test.tsx (12.174 s)
  ● AddRemoveThreepids › should add a phone number

    thrown: "Exceeded timeout of 5000 ms for a test.
    Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

      187 |     });
      188 |
    > 189 |     it("should add a phone number", async () => {
          |     ^
      190 |         const onChangeFn = jest.fn();
      191 |         mocked(client.requestAdd3pidMsisdnToken).mockResolvedValue({
      192 |             sid: "1",

      at it (test/components/views/settings/AddRemoveThreepids-test.tsx:189:5)
      at Object.describe (test/components/views/settings/AddRemoveThreepids-test.tsx:40:1)

https://github.com/element-hq/matrix-react-sdk/actions/runs/10846560527/job/30099765623#step:7:4319
@richvdh richvdh added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Developer-Experience O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Z-Flaky-Test A test is raising false alarms T-Defect labels Sep 13, 2024
@richvdh
Copy link
Member Author

richvdh commented Sep 13, 2024

https://github.com/matrix-org/matrix-js-sdk/actions/runs/10851964582/job/30116914204

@richvdh richvdh mentioned this issue Sep 14, 2024
Merged
4 tasks
@richvdh
Copy link
Member Author

richvdh commented Sep 14, 2024

https://github.com/matrix-org/matrix-js-sdk/actions/runs/10852292938/job/30118002140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Developer-Experience O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Flaky-Test A test is raising false alarms
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@richvdh