Enable Element Call to be consumed as a package within a larger app #2922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not generally available in browser environments and can be easily replaced by TextEncoder.
The former is unsupported and doesn't get relative paths right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to add Element Call as a dependency of Element Web and package it with the application, we should make
yarn packproduce a built copy. Then it can be added as a simple Git dependency to projects using any modern package manager like Yarn Berry or NPM, and it will be saved and built in the local package cache.Unfortunately, we don't use modern package managers yet for our web applications, we use Yarn Classic. This is in draft while I ask around about whether now is a good time to change that.
Part of element-hq/element-web#23908