Use .ts files for vite config for type safety #2912
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
requested changes
Dec 19, 2024
tsconfig.json
Outdated
| @@ -18,6 +18,7 @@ | |||
| // Workaround for https://github.com/microsoft/TypeScript/issues/55132 | |||
| "useDefineForClassFields": false, | |||
| "allowImportingTsExtensions": true, | |||
| "skipLibCheck": true, | |||
There was a problem hiding this comment.
This seems to be a step back in how strict we do our typing.
Are we sure we want this? Is there no way to fix the reason we add this with yarns resolutions?
Can it get a comment why we need this now?
There was a problem hiding this comment.
I concur that this is a backwards step. Unfortunately it's not just the case of some resolutions.
The main culprit appears to be @codecov/vite-plugin.
I will make this draft and lift the one material change over to a simpler PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out we've been using an unsupported sentry config option for some time.
By converting to TS it should help with maintainability.