Improve Search onChange signature #177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avoid casting in the application
Deploying compound-web with
|
| Latest commit: |
73ec7ac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fa4c218d.compound-web.pages.dev |
| Branch Preview URL: | https://langleyd-search-change-event.compound-web.pages.dev |
dbkr
approved these changes
Jun 6, 2024
| const query = "my query"; | ||
| await act(async () => { | ||
| const input = screen.getByRole("searchbox"); | ||
| await userEvent.type(input, query); |
There was a problem hiding this comment.
As far as I understand, the user-event library handles this so it doesn't need to be wrapped in an act(). At least, user-event's examples don't use act(): https://testing-library.com/docs/user-event/intro/#writing-tests-with-userevent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
React.ChangeEvent<HTMLInputElement>in the onChange signature of theSearchcomponent to avoid having to cast it in the application layer.