[patch] try fixing tests on windows

electrovir · Sep 11, 2024 · c8b0579 · c8b0579
1 parent 6898db7
commit c8b0579
Show file tree

Hide file tree

Showing 8 changed files with 25 additions and 15 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -10,12 +10,12 @@ concurrency:
     cancel-in-progress: true
 
 jobs:
-    build:
+    tests:
         runs-on: ${{ matrix.os }}
         strategy:
             fail-fast: false
             matrix:
-                os: [ubuntu-latest, macos-latest]
+                os: [macos-latest, ubuntu-latest, windows-latest]
         steps:
             - uses: actions/[email protected]
             - name: Use Node.js ${{ matrix.node-version }}
@@ -26,10 +26,10 @@ jobs:
             - if: runner.os == 'Windows'
               shell: bash
               run: |
-                  npm install npm
+                  npm i npm
             - name: run test
               shell: bash
               run: |
                   npm ci
-                  npx playwright install --with-deps
+                  npm run format package.json
                   npm run test:all
diff --git a/packages/compile/src/compile.test.ts b/packages/compile/src/compile.test.ts
@@ -18,7 +18,7 @@ describe(virmatorCompilePlugin.name, () => {
                  * are stable.
                  */
                 if (logType === LogOutputType.standard) {
-                    return arg.replace(/ Version.+/, '');
+                    return arg;
                 }
                 return arg;
             },

diff --git a/packages/docs/src/docs.ts b/packages/docs/src/docs.ts
@@ -12,6 +12,7 @@ import {
 import {ChalkInstance} from 'chalk';
 import mri from 'mri';
 import {basename, join} from 'node:path';
+import {pathToFileURL} from 'node:url';
 import type * as Typedoc from 'typedoc';
 
 /** A virmator plugin for checking and generating documentation. */
@@ -160,9 +161,14 @@ export const virmatorDocsPlugin = defineVirmatorPlugin(
             }
 
             // dynamic imports are not branches
-            /* node:coverage ignore next 2 */
-            const config = (await import(join(packageDir, configs.docs.configs.typedoc.copyToPath)))
-                .typeDocConfig as Typedoc.TypeDocOptions;
+            /* node:coverage ignore next 7 */
+            const config = (
+                await import(
+                    pathToFileURL(
+                        join(packageDir, configs.docs.configs.typedoc.copyToPath),
+                    ).toString()
+                )
+            ).typeDocConfig as Typedoc.TypeDocOptions;
 
             await runTypedoc({
                 checkOnly,

diff --git a/packages/frontend/src/frontend.test.ts b/packages/frontend/src/frontend.test.ts
@@ -22,7 +22,7 @@ describe(virmatorFrontendPlugin.name, () => {
             dir,
             {
                 logTransform(logType, log) {
-                    return log.replace(/built in [\dm]+s/, 'built');
+                    return log.replace(/built in [\d.m]+s/g, 'built');
                 },
             },
         );

diff --git a/packages/frontend/src/frontend.ts b/packages/frontend/src/frontend.ts
@@ -4,6 +4,7 @@ import {defineVirmatorPlugin, NpmDepType, PackageType, VirmatorEnv} from '@virma
 import mri from 'mri';
 import {cp, rm} from 'node:fs/promises';
 import {join, relative, resolve} from 'node:path';
+import {pathToFileURL} from 'node:url';
 import type {UserConfig} from 'vite';
 
 /** A virmator plugin for running and building frontend packages. */
@@ -109,7 +110,9 @@ export const virmatorFrontendPlugin = defineVirmatorPlugin(
             usedCommands.frontend?.subCommands.build || usedCommands.frontend?.subCommands.preview;
         const configPath = args.config || configs.frontend.configs.vite.fullCopyToPath;
 
-        const viteConfig = await ((await import(configPath)).default as MaybePromise<UserConfig>);
+        const viteConfig = await ((
+            await import(pathToFileURL(configPath).toString())
+        ).default as MaybePromise<UserConfig>);
 
         const rootDir: string = viteConfig.root ? resolve(cwd, viteConfig.root) : cwd;
         const outDir: string = resolve(rootDir, viteConfig.build?.outDir || 'dist');

diff --git a/packages/init/configs/github/workflows/tests-node.yml b/packages/init/configs/github/workflows/tests-node.yml
@@ -15,7 +15,7 @@ jobs:
         strategy:
             fail-fast: false
             matrix:
-                os: [ubuntu-latest, windows-latest, macos-latest]
+                os: [macos-latest, ubuntu-latest, windows-latest]
         steps:
             - uses: actions/[email protected]
             - name: Use Node.js ${{ matrix.node-version }}
@@ -26,7 +26,7 @@ jobs:
             - if: runner.os == 'Windows'
               shell: bash
               run: |
-                  npm install npm
+                  npm i npm --no-save
             - name: run test
               shell: bash
               run: |

diff --git a/packages/init/configs/github/workflows/tests-web.yml b/packages/init/configs/github/workflows/tests-web.yml
@@ -15,7 +15,7 @@ jobs:
         strategy:
             fail-fast: false
             matrix:
-                os: [ubuntu-latest, windows-latest, macos-latest]
+                os: [macos-latest, ubuntu-latest, windows-latest]
         steps:
             - uses: actions/[email protected]
             - name: Use Node.js ${{ matrix.node-version }}
@@ -26,7 +26,7 @@ jobs:
             - if: runner.os == 'Windows'
               shell: bash
               run: |
-                  npm install npm
+                  npm i npm --no-save
             - name: run test
               shell: bash
               run: |

diff --git a/packages/test/src/test.ts b/packages/test/src/test.ts
@@ -12,6 +12,7 @@ import {glob} from 'glob';
 import mri from 'mri';
 import {rm, writeFile} from 'node:fs/promises';
 import {join, relative} from 'node:path';
+import {pathToFileURL} from 'node:url';
 
 /** A virmator plugin for running tests. */
 export const virmatorTestPlugin = defineVirmatorPlugin(
@@ -282,7 +283,7 @@ export const virmatorTestPlugin = defineVirmatorPlugin(
                           configPath,
                       ];
 
-                const webTestRunnerConfig = (await import(configPath))
+                const webTestRunnerConfig = (await import(pathToFileURL(configPath).toString()))
                     .default as Partial<TestRunnerConfig>;
 
                 const includeCoverage = usedCommands.test.subCommands.web.subCommands.coverage;